Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a couple of minor changes from #48:
DecodeCharError
renamed toEncodeToCharError
since that's what we're trying to do when the error occursCoordEncodingError
which is the "parent" ofEncodeToCharError
:The reason for 3. is that we lack index or
Coord
information insideencode()
. When anEncodeToCharError
occurs there, we early-return back up to its callingencode_coordinates()
parent function, where we do have index andCoord
info, so we map the bare error onto the richer "parent".This change has no perf implications in my testing.